Skip to content

Update stalebot to take 5 actions per hour #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2020
Merged

Update stalebot to take 5 actions per hour #3922

merged 2 commits into from
Nov 25, 2020

Conversation

dhruvmanila
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila requested a review from cclauss as a code owner November 22, 2020 11:04
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 22, 2020
@cclauss
Copy link
Member

cclauss commented Nov 22, 2020

I was thinking 5 PRs a day, not every hour. Do we really need to run this job every hour?

@dhruvmanila
Copy link
Member Author

That is not up to us. This job runs every hour because of the rate limit and is scheduled directly into the code. As mentioned, the important parameters are daysUntilStale and daysUntilClose. limitPerRun is only used to determine how quickly you want the bot to label/close.

Why per hour? The bot requires a token to do its job and that token lasts for one hour plus there are rate limits and also the app could be blocked if GitHub finds it abusing the limit.

@dhruvmanila
Copy link
Member Author

@cclauss Any update regarding this?

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 25, 2020
@dhruvmanila dhruvmanila merged commit 5eb5483 into master Nov 25, 2020
@dhruvmanila dhruvmanila deleted the patch-stale-bot branch November 25, 2020 07:53
@vzvu3k6k vzvu3k6k mentioned this pull request Jan 2, 2021
Merged
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
Update stalebot to take 5 actions per hour (TheAlgorithms#3922)
96bc360 
* Update stalebot to take 5 actions per hour

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@dhruvmanila @peRFectBeliever
Update stalebot to take 5 actions per hour (TheAlgorithms#3922)
c042923 
* Update stalebot to take 5 actions per hour

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Update stalebot to take 5 actions per hour (TheAlgorithms#3922)
f28d52d 
* Update stalebot to take 5 actions per hour

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila @shermanhui
Update stalebot to take 5 actions per hour (TheAlgorithms#3922)
070cd1b 
* Update stalebot to take 5 actions per hour

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss